DCHECK(CalledOnValidThread()) for ScopedUserPrefUpdate

DCHECK(CalledOnValidThread()) for ScopedUserPrefUpdate

BUG=392781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282362

[Bernhard Bauer, 2014-07-10 09:12:09]

https://codereview.chromium.org/383683002/diff/1/base/prefs/scoped_user_pref_...
File base/prefs/scoped_user_pref_update.cc (right):

https://codereview.chromium.org/383683002/diff/1/base/prefs/scoped_user_pref_...
base/prefs/scoped_user_pref_update.cc:22: DCHECK(CalledOnValidThread());
This check isn't necessary; ScopedUserPrefUpdateBase inherits from nonThreadSafe
(which is where the CalledOnValidThread() comes from), and that will DCHECK in
its destructor.

[battre, 2014-07-10 11:16:33]

Hi Bernhard,

could you please review this? The trybots seem to be happy with this.

Thanks,
Dominic

https://codereview.chromium.org/383683002/diff/1/base/prefs/scoped_user_pref_...
File base/prefs/scoped_user_pref_update.cc (right):

https://codereview.chromium.org/383683002/diff/1/base/prefs/scoped_user_pref_...
base/prefs/scoped_user_pref_update.cc:22: DCHECK(CalledOnValidThread());
On 2014/07/10 09:12:09, Bernhard Bauer wrote:
> This check isn't necessary; ScopedUserPrefUpdateBase inherits from
nonThreadSafe
> (which is where the CalledOnValidThread() comes from), and that will DCHECK in
> its destructor.

Done.

[Bernhard Bauer, 2014-07-10 11:22:39]

LGTM

[battre, 2014-07-10 11:32:00]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2014-07-10 11:32:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/battre@chromium.org/383683002/20001

[commit-bot: I haz the power, 2014-07-10 15:32:15]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-10 17:09:55]

Change committed as 282362