Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: base/prefs/scoped_user_pref_update.cc

Issue 383683002: DCHECK(CalledOnValidThread()) for ScopedUserPrefUpdate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed on unnecessary DCHECK Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/pref_service.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/scoped_user_pref_update.h" 5 #include "base/prefs/scoped_user_pref_update.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_notifier.h" 8 #include "base/prefs/pref_notifier.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 10
11 namespace subtle { 11 namespace subtle {
12 12
13 ScopedUserPrefUpdateBase::ScopedUserPrefUpdateBase(PrefService* service, 13 ScopedUserPrefUpdateBase::ScopedUserPrefUpdateBase(PrefService* service,
14 const char* path) 14 const char* path)
15 : service_(service), 15 : service_(service),
16 path_(path), 16 path_(path),
17 value_(NULL) {} 17 value_(NULL) {
18 DCHECK(service_->CalledOnValidThread());
19 }
18 20
19 ScopedUserPrefUpdateBase::~ScopedUserPrefUpdateBase() { 21 ScopedUserPrefUpdateBase::~ScopedUserPrefUpdateBase() {
20 Notify(); 22 Notify();
21 } 23 }
22 24
23 base::Value* ScopedUserPrefUpdateBase::GetValueOfType(base::Value::Type type) { 25 base::Value* ScopedUserPrefUpdateBase::GetValueOfType(base::Value::Type type) {
26 DCHECK(CalledOnValidThread());
24 if (!value_) 27 if (!value_)
25 value_ = service_->GetMutableUserPref(path_.c_str(), type); 28 value_ = service_->GetMutableUserPref(path_.c_str(), type);
26 return value_; 29 return value_;
27 } 30 }
28 31
29 void ScopedUserPrefUpdateBase::Notify() { 32 void ScopedUserPrefUpdateBase::Notify() {
30 if (value_) { 33 if (value_) {
31 service_->ReportUserPrefChanged(path_); 34 service_->ReportUserPrefChanged(path_);
32 value_ = NULL; 35 value_ = NULL;
33 } 36 }
34 } 37 }
35 38
36 } // namespace subtle 39 } // namespace subtle
OLDNEW
« no previous file with comments | « base/prefs/pref_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698