fpdfsdk/src/fpdftext.cpp - Issue 383563002: Fix an out-of-boundary issue for wide string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdftext.cpp

Issue 383563002: Fix an out-of-boundary issue for wide string (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add WStringLength function Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdftext.cpp

diff --git a/fpdfsdk/src/fpdftext.cpp b/fpdfsdk/src/fpdftext.cpp

index 1aa05421243a7dd29e3cbf9910c686cabd98ba38..869ec48ba6a2893ee98018d5b857a31625690cef 100644

--- a/fpdfsdk/src/fpdftext.cpp

+++ b/fpdfsdk/src/fpdftext.cpp

@@ -11,7 +11,7 @@

#include <tchar.h>

#endif

- // jabdelmalek: commented out to build on Linux. Not used.

+ // jabdelmalek: commented out to build on Linux. Not used.

// extern HANDLE g_hModule;

DLLEXPORT FPDF_TEXTPAGE STDCALL FPDFText_LoadPage(FPDF_PAGE page)

@@ -162,7 +162,8 @@ DLLEXPORT FPDF_SCHHANDLE STDCALL FPDFText_FindStart(FPDF_TEXTPAGE text_page,FPDF

try

{

textpageFind=IPDF_TextPageFind::CreatePageFind((IPDF_TextPage*)text_page);

- textpageFind->FindFirst(CFX_WideString::FromUTF16LE(findwhat),flags,start_index);

+ FX_STRSIZE len = CFX_WideString::WStringLength(findwhat);

+ textpageFind->FindFirst(CFX_WideString::FromUTF16LE(findwhat, len),flags,start_index);

}

catch (...)

{

« no previous file with comments | « fpdfsdk/src/fpdfdoc.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »