fpdfsdk/src/fpdfdoc.cpp - Issue 383563002: Fix an out-of-boundary issue for wide string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfdoc.cpp

Issue 383563002: Fix an out-of-boundary issue for wide string (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add WStringLength function Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfdoc.cpp

diff --git a/fpdfsdk/src/fpdfdoc.cpp b/fpdfsdk/src/fpdfdoc.cpp

index edd61f9e516431cd6faa39fc220c11c4c000365a..e974ffbcf245a561c39f7a6d9305139a4e9edfdc 100644

--- a/fpdfsdk/src/fpdfdoc.cpp

+++ b/fpdfsdk/src/fpdfdoc.cpp

@@ -36,7 +36,8 @@ DLLEXPORT FPDF_BOOKMARK STDCALL FPDFBookmark_Find(FPDF_DOCUMENT document, FPDF_W

CPDF_Document* pDoc = (CPDF_Document*)document;

CPDF_BookmarkTree tree(pDoc);

- CFX_WideString wstr = CFX_WideString::FromUTF16LE(title);

+ FX_STRSIZE len = CFX_WideString::WStringLength(title);

+ CFX_WideString wstr = CFX_WideString::FromUTF16LE(title, len);

return FindBookmark(tree, NULL, wstr);

}

« no previous file with comments | « core/src/fxge/win32/fx_win32_device.cpp ('k') | fpdfsdk/src/fpdftext.cpp » ('j') | no next file with comments »