Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 383433002: Revert of Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Ignacio Solla
Project:
chromium
Visibility:
Public.

Description

Revert of Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes (https://codereview.chromium.org/364043002/) Reason for revert: revert this as all related CLs are submitted Original issue's description: > Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes > > there are 2 changes needs to be submitted before we reenable the tests: > 1. https://codereview.chromium.org/290643005/ and > 2. https://codereview.chromium.org/292573004/ > > the blink change will break all the tests, so we need to reenable the tests after the chromium change lands > > BUG=367346 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281165 TBR=boliu@chromium.org BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 5 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qinmin
Created Revert of Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes
6 years, 5 months ago (2014-07-09 16:34:10 UTC) #1
boliu
The CQ bit was unchecked by boliu@chromium.org
6 years, 5 months ago (2014-07-09 16:34:54 UTC) #2
boliu
ditto...
6 years, 5 months ago (2014-07-09 16:35:05 UTC) #3
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-09 16:51:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/383433002/1
6 years, 5 months ago (2014-07-09 16:52:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 21:05:23 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 23:00:36 UTC) #7
Message was sent while issue was closed.
Change committed as 282158

Powered by Google App Engine
This is Rietveld 408576698