Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 383293002: Start of adding enums for error codes (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Start of adding enums for error codes I started with CreateNode so that you can get a feel for how this would look. I may need a couple of other error codes, but not many more. BUG=384437 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -17 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 3 chunks +13 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +12 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 5 months ago (2014-07-11 21:25:44 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 5 months ago (2014-07-11 21:34:05 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-11 21:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/383293002/1
6 years, 5 months ago (2014-07-11 21:43:00 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 00:49:07 UTC) #5
Message was sent while issue was closed.
Change committed as 282760

Powered by Google App Engine
This is Rietveld 408576698