Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.cc

Issue 383293002: Start of adding enums for error codes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/view_manager_service_impl.cc
diff --git a/mojo/services/view_manager/view_manager_service_impl.cc b/mojo/services/view_manager/view_manager_service_impl.cc
index dd3fc7087aa1db62909dbf0516cf487353b1ff36..a4390262197533f4a17916edb60965b3ae0fcb03 100644
--- a/mojo/services/view_manager/view_manager_service_impl.cc
+++ b/mojo/services/view_manager/view_manager_service_impl.cc
@@ -542,16 +542,18 @@ Array<NodeDataPtr> ViewManagerServiceImpl::NodesToNodeDatas(
void ViewManagerServiceImpl::CreateNode(
Id transport_node_id,
- const Callback<void(bool)>& callback) {
+ const Callback<void(ErrorCode)>& callback) {
const NodeId node_id(NodeIdFromTransportId(transport_node_id));
- if (node_id.connection_id != id_ ||
- node_map_.find(node_id.node_id) != node_map_.end()) {
- callback.Run(false);
- return;
+ ErrorCode error_code = ERROR_CODE_NONE;
+ if (node_id.connection_id != id_) {
+ error_code = ERROR_CODE_ILLEGAL_ARGUMENT;
+ } else if (node_map_.find(node_id.node_id) != node_map_.end()) {
+ error_code = ERROR_CODE_VALUE_IN_USE;
+ } else {
+ node_map_[node_id.node_id] = new Node(root_node_manager_, node_id);
+ known_nodes_.insert(transport_node_id);
}
- node_map_[node_id.node_id] = new Node(root_node_manager_, node_id);
- known_nodes_.insert(transport_node_id);
- callback.Run(true);
+ callback.Run(error_code);
}
void ViewManagerServiceImpl::DeleteNode(
« no previous file with comments | « mojo/services/view_manager/view_manager_service_impl.h ('k') | mojo/services/view_manager/view_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698