Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 383273002: OpenSSL: forward to BoringSSL. (Closed)

Created:
6 years, 5 months ago by agl
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
Sergey Ulanov
Base URL:
https://chromium.googlesource.com/chromium/deps/openssl.git@master
Visibility:
Public.

Description

OpenSSL: forward to BoringSSL. This change will sit in the OpenSSL deps repo. When we switch to BoringSSL, that patch will update DEPS to point to this revision. This avoids having to update webrtc and libjingle repos at the same time. The NaCl build is removed because I believe that all the pointers to it are in the main Chromium repo and can be switched over. I'd rather get a clear build error than linking in both OpenSSL and BoringSSL. (Also, forwarding doesn't appear to work for NaCl targets.) BUG=393317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -173 lines) Patch
M openssl.gyp View 1 chunk +4 lines, -108 lines 0 comments Download
D openssl_nacl.gyp View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
agl
6 years, 5 months ago (2014-07-11 20:36:04 UTC) #1
Ryan Sleevi
Sergey knows about the NaCl build and what would need to be updated. I'd hold ...
6 years, 5 months ago (2014-07-11 20:52:11 UTC) #2
agl
6 years, 5 months ago (2014-07-11 20:59:37 UTC) #3
On 2014/07/11 20:52:11, Ryan Sleevi wrote:
> Sergey knows about the NaCl build and what would need to be updated.

I can build remoting_client_plugin_nacl successfully in my client, which is the
target that Sergey suggested.

> I'd hold off on landing this, lest we need to do any further OpenSSL patches,
> until we're ready to flop over.

Agreed, although I hope that's next week.

Powered by Google App Engine
This is Rietveld 408576698