tools/json_schema_compiler/test/callbacks_unittest.cc - Issue 383263005: Remove more CreateIntegerValue calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/test/callbacks_unittest.cc

Issue 383263005: Remove more CreateIntegerValue calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: s/SetBoolean/SetInteger Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/test/callbacks_unittest.cc

diff --git a/tools/json_schema_compiler/test/callbacks_unittest.cc b/tools/json_schema_compiler/test/callbacks_unittest.cc

index e69289eb522fcdd39c962bc2f4280f57e6382bc1..001e977bf07a74c1a75105bbe18972acdae2cdbd 100644

--- a/tools/json_schema_compiler/test/callbacks_unittest.cc

+++ b/tools/json_schema_compiler/test/callbacks_unittest.cc

@@ -30,7 +30,7 @@ TEST(JsonSchemaCompilerCallbacksTest, ReturnsMultipleResultCreate) {

base::DictionaryValue* expected_dict = new base::DictionaryValue();

expected_dict->SetString("state", "foo");

base::ListValue expected;

- expected.Append(base::Value::CreateIntegerValue(5));

+ expected.Append(new base::FundamentalValue(5));

expected.Append(expected_dict);

EXPECT_TRUE(results->Equals(&expected));

}