On Android uses system properties instead of environment variables.

On Android uses system properties instead of environment variables.

On Android, setting environment variables is difficult. The idiomatic
way to communicate configuration options to programs appears to be
through "system properties". This change uses system properties
for DART_FORWARDING_PRINT to get testing up and going. Later,
we'll also need to replace other uses of environment variables with
it.

R=antonm@google.com, asiva@google.com, vsm@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1476

[Anton Muhin, 2013-10-24 06:01:49]

lgtm

https://codereview.chromium.org/38323002/diff/30001/Source/bindings/dart/Dart...
File Source/bindings/dart/DartController.cpp (right):

https://codereview.chromium.org/38323002/diff/30001/Source/bindings/dart/Dart...
Source/bindings/dart/DartController.cpp:191: const char * const printClosure =
(propLen > 0) ?
maybe introduce bool forwardPrint which is platform specific and then


const char * const printClosure = forwardPrint ? " _fPC" : (isDOMEnable ? "_pC"
: "_pISPC"

?

[siva, 2013-10-24 16:37:33]

lgtm

[vsm, 2013-10-24 16:55:19]

lgtm

Consider factoring out getenv into something like:

DartUtilities::getProperty(...) {
  // Android, non android impls
}

Post-M8, we're planning on transitioning to command line flags instead of env
variables.  Will that work for Android?

[zra, 2013-10-24 16:59:26]

On 2013/10/24 16:55:19, vsm wrote:
> lgtm
> 
> Consider factoring out getenv into something like:
> 
> DartUtilities::getProperty(...) {
>   // Android, non android impls
> }
> 
> Post-M8, we're planning on transitioning to command line flags instead of env
> variables.  Will that work for Android?

I'll factor it out.

I've seen evidence that command line flags can work. I'm not sure how difficult
it would be, but it's still probably more compatible than environment variables.

[zra, 2013-10-24 18:53:04]

On 2013/10/24 16:59:26, zra wrote:
> On 2013/10/24 16:55:19, vsm wrote:
> > lgtm
> > 
> > Consider factoring out getenv into something like:
> > 
> > DartUtilities::getProperty(...) {
> >   // Android, non android impls
> > }
> > 
> > Post-M8, we're planning on transitioning to command line flags instead of
env
> > variables.  Will that work for Android?
> 
> I'll factor it out.
> 
> I've seen evidence that command line flags can work. I'm not sure how
difficult
> it would be, but it's still probably more compatible than environment
variables.

Meant to say: I'll factor it out when I deal with DART_FLAGS. Just
building/testing desktop Dartium now as a sanity check, then I'll commit.

[zra, 2013-10-24 20:48:55]

Committed patchset #3 manually as r1476 (presubmit successful).