ifdef more extensions code to be used only when extensions are enabled.

ifdef more extensions code to be used only when extensions are enabled.

BUG=349436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283327

[Lei Zhang, 2014-07-11 22:11:11]

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:660: //
Build in additional protection for the chrome web store origin.
tsepez: Can we drop this on Android?

[Yoyo Zhou, 2014-07-11 23:52:29]

LGTM

[Tom Sepez, 2014-07-14 16:12:43]

LGTM with comments.

https://codereview.chromium.org/383213007/diff/1/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/383213007/diff/1/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:2259: ProfileIOData* io_data =
ProfileIOData::FromResourceContext(context);
nit: can these declarations move into the #if block below since they don't seem
to be used outside of the block following
 if (container_type == WINDOW_CONTAINER_TYPE_BACKGROUND) {

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:660: //
Build in additional protection for the chrome web store origin.
On 2014/07/11 22:11:11, Lei Zhang wrote:
> tsepez: Can we drop this on Android?
Theoretically yes, but it is a nice line of defense against future changes to
android.  I'd vote for keeping it.

[Lei Zhang, 2014-07-14 21:26:06]

https://codereview.chromium.org/383213007/diff/1/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/383213007/diff/1/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:2259: ProfileIOData* io_data =
ProfileIOData::FromResourceContext(context);
On 2014/07/14 16:12:43, Tom Sepez wrote:
> nit: can these declarations move into the #if block below since they don't
seem
> to be used outside of the block following
>  if (container_type == WINDOW_CONTAINER_TYPE_BACKGROUND) {

Thanks, done.

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/383213007/diff/1/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:660: //
Build in additional protection for the chrome web store origin.
On 2014/07/14 16:12:43, Tom Sepez wrote:
> On 2014/07/11 22:11:11, Lei Zhang wrote:
> > tsepez: Can we drop this on Android?
> Theoretically yes, but it is a nice line of defense against future changes to
> android.  I'd vote for keeping it.

Done. We will revisit this when I try to remove chrome/common/extensions.

[Lei Zhang, 2014-07-14 21:26:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-14 21:27:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/383213007/40001

[commit-bot: I haz the power, 2014-07-15 10:48:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-15 16:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-15 16:50:12]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Lei Zhang, 2014-07-15 19:42:21]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-07-15 19:46:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/383213007/40001

[commit-bot: I haz the power, 2014-07-16 04:14:09]

Change committed as 283327