chrome/browser/metrics/chrome_stability_metrics_provider.cc - Issue 383213007: ifdef more extensions code to be used only when extensions are enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 383213007: ifdef more extensions code to be used only when extensions are enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments, lint Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/protected_media_identifier_permission_context.cc ('k') | chrome/browser/prerender/prerender_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc

diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

index f39bbd46caf00447cdeff19043f1b62e28bbe866..7f669eb91bd3167fcbc9f0aad4f625d3f3192d0c 100644

--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc

+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

@@ -20,7 +20,10 @@

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

+#if defined(ENABLE_EXTENSIONS)

#include "extensions/browser/process_map.h"

+#endif

#if defined(ENABLE_PLUGINS)

#include "chrome/browser/metrics/plugin_metrics_provider.h"

@@ -195,9 +198,12 @@ void ChromeStabilityMetricsProvider::LogRendererCrash(

content::RenderProcessHost* host,

base::TerminationStatus status,

int exit_code) {

- bool was_extension_process =

- extensions::ProcessMap::Get(host->GetBrowserContext())

- ->Contains(host->GetID());

+ bool was_extension_process = false;

+#if defined(ENABLE_EXTENSIONS)

+ was_extension_process =

+ extensions::ProcessMap::Get(host->GetBrowserContext())->Contains(

+ host->GetID());

+#endif

if (status == base::TERMINATION_STATUS_PROCESS_CRASHED ||

status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {

if (was_extension_process) {