Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: ppapi/proxy/ppb_instance_proxy.cc

Issue 383143003: Pepper: Make sure 'out' params are initialized for all code paths. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/ppb_image_data_proxy.cc ('K') | « ppapi/proxy/ppb_image_data_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/ppb_instance_proxy.cc
diff --git a/ppapi/proxy/ppb_instance_proxy.cc b/ppapi/proxy/ppb_instance_proxy.cc
index 2780022d605b2e13f7efa82dbb956e71ff575379..f227e34968aaacf34538b17848411149a776f8b9 100644
--- a/ppapi/proxy/ppb_instance_proxy.cc
+++ b/ppapi/proxy/ppb_instance_proxy.cc
@@ -497,6 +497,9 @@ void PPB_Instance_Proxy::ZoomLimitsChanged(PP_Instance instance,
PP_Var PPB_Instance_Proxy::GetDocumentURL(PP_Instance instance,
PP_URLComponents_Dev* components) {
+ // Clear |components| so we don't send unitialized memory to the plugin.
+ // https://crbug.com/391023.
+ memset(components, 0, sizeof(*components));
dmichael (off chromium) 2014/07/11 15:22:26 ditto
bbudge 2014/07/11 17:01:55 Backed out my change here. |components| may be NUL
ReceiveSerializedVarReturnValue result;
PP_URLComponents_Dev url_components = {{0}};
dispatcher()->Send(new PpapiHostMsg_PPBInstance_GetDocumentURL(
« ppapi/proxy/ppb_image_data_proxy.cc ('K') | « ppapi/proxy/ppb_image_data_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698