Pepper: Make sure 'out' params are initialized for all code paths.

ppapi/proxy/ppb_instance_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_instance_proxy.h"
 
 #include "base/memory/ref_counted.h"
 #include "build/build_config.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/pp_time.h"
@@ skipping 479 matching lines @@
 
 void PPB_Instance_Proxy::ZoomLimitsChanged(PP_Instance instance,
                                            double minimum_factor,
                                            double maximium_factor) {
   // Not proxied yet.
   NOTIMPLEMENTED();
 }
 
 PP_Var PPB_Instance_Proxy::GetDocumentURL(PP_Instance instance,
                                           PP_URLComponents_Dev* components) {
+  // Clear |components| so we don't send unitialized memory to the plugin.
+  // https://crbug.com/391023.
+  memset(components, 0, sizeof(*components));

[dmichael (off chromium), 2014/07/11 15:22:26]

ditto

[bbudge, 2014/07/11 17:01:55]

Backed out my change here. |components| may be NULL. If not, code below makes
sure components isn't uninitialized.

   ReceiveSerializedVarReturnValue result;
   PP_URLComponents_Dev url_components = {{0}};
   dispatcher()->Send(new PpapiHostMsg_PPBInstance_GetDocumentURL(
       API_ID_PPB_INSTANCE, instance, &url_components, &result));
   if (components)
     *components = url_components;
   return result.Return(dispatcher());
 }
 
 #if !defined(OS_NACL)
@@ skipping 926 matching lines @@
     PP_Instance instance) {
   InstanceData* data = static_cast<PluginDispatcher*>(dispatcher())->
       GetInstanceData(instance);
   if (!data)
     return;  // Instance was probably deleted.
   data->should_do_request_surrounding_text = false;
 }
 
 }  // namespace proxy
 }  // namespace ppapi