Chromium Code Reviews Chromium Code Reviews
Issue 38313002:
Remove <video> width and height attributes from intrisic size logic (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/media/video-intrinsic-width-height.html |
| diff --git a/LayoutTests/media/video-intrinsic-width-height.html b/LayoutTests/media/video-intrinsic-width-height.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..a43cdc28f4d2d0340072575a90cf153b3f86142c |
| --- /dev/null |
| +++ b/LayoutTests/media/video-intrinsic-width-height.html |
| @@ -0,0 +1,39 @@ |
| +<!DOCTYPE html> |
| +<html> |
| + <head> |
| + <title><video> intrinsic width/height</title> |
| + <script src="../resources/testharness.js"></script> |
| + <script src="../resources/testharnessreport.js"></script> |
| + </head> |
| + <body> |
| + <div id="log"></div> |
| + <!-- These tests assume that the default intrinsic width is 300x150, so that the default |
| + intrinsic ratio is 2:1. This is no longer per spec, but is what is implemented. --> |
| + <video title="no width/height attributes" |
| + data-expected-width="300" data-expected-height="150"></video> |
| + <video title="only width attribute" |
| + data-expected-width="100" data-expected-height="50" |
| + width="100"></video> |
| + <video title="only height attribute" |
| + data-expected-width="200" data-expected-height="100" |
| + height="100"></video> |
| + <video title="both width/height attributes" |
| + data-expected-width="100" data-expected-height="100" |
| + width="100" height="100"></video> |
| + <!-- A width:height ratio other than 2:1 and overriding the specified style must be used to |
| + verify that width/height does not influence intrinsic ratio --> |
| + <video title="both width/height attributes and style" |
| + data-expected-width="300" data-expected-height="150" |
| + width="100" height="100" style="width: auto; height: auto"></video> |
| + <script> |
| + Array.prototype.forEach.call(document.querySelectorAll('video'), function(video) |
| + { |
|
acolwell GONE FROM CHROMIUM
2013/10/24 17:19:32
nit: {} should not be 4-space indented here and be
philipj_slow
2013/10/24 19:26:07
Indeed, I've grepped a bit and the majority agree
|
| + test(function() |
| + { |
| + assert_equals(video.clientWidth, parseInt(video.dataset.expectedWidth), "width"); |
| + assert_equals(video.clientHeight, parseInt(video.dataset.expectedHeight), "height"); |
| + }, video.title); |
| + }); |
| + </script> |
| + </body> |
| +</html> |
