LayoutTests/media/video-intrinsic-width-height.html - Issue 38313002: Remove <video> width and height attributes from intrisic size logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-intrinsic-width-height.html

Issue 38313002: Remove <video> width and height attributes from intrisic size logic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: expanded test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title><video> intrinsic width/height</title>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <div id="log"></div>

	10 <!-- These tests assume that the default intrinsic width is 300x150, so that the default

	11 intrinsic ratio is 2:1. This is no longer per spec, but is what is implemented. -->

	12 <video title="no width/height attributes"

	13 data-expected-width="300" data-expected-height="150"></video>

	14 <video title="only width attribute"

	15 data-expected-width="100" data-expected-height="50"

	16 width="100"></video>

	17 <video title="only height attribute"

	18 data-expected-width="200" data-expected-height="100"

	19 height="100"></video>

	20 <video title="both width/height attributes"

	21 data-expected-width="100" data-expected-height="100"

	22 width="100" height="100"></video>

	23 <!-- A width:height ratio other than 2:1 and overriding the specified st yle must be used to

	24 verify that width/height does not influence intrinsic ratio -->

	25 <video title="both width/height attributes and style"

	26 data-expected-width="300" data-expected-height="150"

	27 width="100" height="100" style="width: auto; height: auto"></vide o>

	28 <script>

	29 Array.prototype.forEach.call(document.querySelectorAll('video'), fun ction(video)

	30 {
	acolwell GONE FROM CHROMIUM 2013/10/24 17:19:32 nit: {} should not be 4-space indented here and be nit: {} should not be 4-space indented here and below. Here is a general style example for this situation. myFunc(function() { doSomething(); }); philipj_slow 2013/10/24 19:26:07 Indeed, I've grepped a bit and the majority agree Show quoted text On 2013/10/24 17:19:32, acolwell wrote: > nit: {} should not be 4-space indented here and below. Here is a general style > example for this situation. > myFunc(function() > { > doSomething(); > }); Indeed, I've grepped a bit and the majority agree with you. Done.
	31 test(function()

	32 {

	33 assert_equals(video.clientWidth, parseInt(video.data set.expectedWidth), "width");

	34 assert_equals(video.clientHeight, parseInt(video.dat aset.expectedHeight), "height");

	35 }, video.title);

	36 });

	37 </script>

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/video-intrinsic-width-height-expected.txt » ('j') | no next file with comments »