LayoutTests/media/video-no-intrinsic-width-height.html - Issue 38313002: Remove <video> width and height attributes from intrisic size logic

Unified Diff: LayoutTests/media/video-no-intrinsic-width-height.html

Issue 38313002: Remove <video> width and height attributes from intrisic size logic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/media/video-no-intrinsic-width-height.html

diff --git a/LayoutTests/media/video-no-intrinsic-width-height.html b/LayoutTests/media/video-no-intrinsic-width-height.html

new file mode 100644

index 0000000000000000000000000000000000000000..3a22e024216e3bc9aaaf747a8c74d08a7f7f9f7e

--- /dev/null

+++ b/LayoutTests/media/video-no-intrinsic-width-height.html

@@ -0,0 +1,12 @@

+<!DOCTYPE html>

+<script src="../resources/testharness.js"></script>

acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nits: please add <html>,<head>, and <body> in the

philipj_slow 2013/10/24 06:07:23 Done.

+<script src="../resources/testharnessreport.js"></script>

+<div id="log"></div>

+<video width=1 height=2 style="width: 100px; height: auto"></video>

+<script>

+test(function() {

acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nit: { goes on the next line in Blink style.

philipj_slow 2013/10/24 06:07:23 Done.

+ var v = document.querySelector("video");

+ assert_equals(v.clientWidth, 100);

+ assert_equals(v.clientHeight, 50);

acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nit: It might be useful to have a comment indicati

philipj_slow 2013/10/24 06:07:23 Done.

+}, "width/height attributes should not influence intrinsic width/height");

acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 I think you should also add extra tests that captu

philipj_slow 2013/10/24 06:07:23 Done.

+</script>

« no previous file with comments | « no previous file | LayoutTests/media/video-no-intrinsic-width-height-expected.txt » ('j') | no next file with comments »