LayoutTests/media/video-no-intrinsic-width-height.html - Issue 38313002: Remove <video> width and height attributes from intrisic size logic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-no-intrinsic-width-height.html

Issue 38313002: Remove <video> width and height attributes from intrisic size logic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>
	acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nits: please add <html>,<head>, and <body> in the nits: please add <html>,<head>, and <body> in the right places & 4-space indent appropriately. philipj_slow 2013/10/24 06:07:23 Done. Show quoted text On 2013/10/23 23:40:06, acolwell wrote: > nits: please add <html>,<head>, and <body> in the right places & 4-space indent > appropriately. Done.
	3 <script src="../resources/testharnessreport.js"></script>

	4 <div id="log"></div>

	5 <video width=1 height=2 style="width: 100px; height: auto"></video>

	6 <script>

	7 test(function() {
	acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nit: { goes on the next line in Blink style. nit: { goes on the next line in Blink style. philipj_slow 2013/10/24 06:07:23 Done. Show quoted text On 2013/10/23 23:40:06, acolwell wrote: > nit: { goes on the next line in Blink style. Done.
	8 var v = document.querySelector("video");

	9 assert_equals(v.clientWidth, 100);

	10 assert_equals(v.clientHeight, 50);
	acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 nit: It might be useful to have a comment indicati nit: It might be useful to have a comment indicating that you are intentionally using a different aspect ratio for width/height than the default size to make sure "auto" copies the default size aspect ratio instead of width/height. philipj_slow 2013/10/24 06:07:23 Done. Show quoted text On 2013/10/23 23:40:06, acolwell wrote: > nit: It might be useful to have a comment indicating that you are intentionally > using a different aspect ratio for width/height than the default size to make > sure "auto" copies the default size aspect ratio instead of width/height. Done.
	11 }, "width/height attributes should not influence intrinsic width/height");
	acolwell GONE FROM CHROMIUM 2013/10/23 23:40:06 I think you should also add extra tests that captu I think you should also add extra tests that capture the no width/height attr & width/height attr w/o style behaviors. philipj_slow 2013/10/24 06:07:23 Done. Show quoted text On 2013/10/23 23:40:06, acolwell wrote: > I think you should also add extra tests that capture the no width/height attr & > width/height attr w/o style behaviors. Done.
	12 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/video-no-intrinsic-width-height-expected.txt » ('j') | no next file with comments »