Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 383123011: Revert 282761 "Change PhoneNumber::SetInfo to only apply formatt..." (Closed)

Created:
6 years, 5 months ago by Ryan Sleevi
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282761 "Change PhoneNumber::SetInfo to only apply formatt..." Possible failure on Android ( http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=21495 ) > Change PhoneNumber::SetInfo to only apply formatting where there is none > > See discussion on https://codereview.chromium.org/347183005/ > > BUG=none > > Review URL: https://codereview.chromium.org/374053007 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -123 lines) Patch
M trunk/src/chrome/browser/autofill/autofill_browsertest.cc View 2 chunks +11 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill/core/browser/personal_data_manager_unittest.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M trunk/src/components/autofill/core/browser/phone_number.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M trunk/src/components/autofill/core/browser/phone_number_i18n.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M trunk/src/components/autofill/core/browser/phone_number_i18n_unittest.cc View 1 chunk +55 lines, -64 lines 0 comments Download
M trunk/src/components/autofill/core/browser/phone_number_unittest.cc View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
6 years, 5 months ago (2014-07-12 02:19:25 UTC) #1
Ryan Sleevi
6 years, 5 months ago (2014-07-12 02:19:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r282778 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698