Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: trunk/src/components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 383123011: Revert 282761 "Change PhoneNumber::SetInfo to only apply formatt..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/autofill/core/browser/personal_data_manager_unittest.cc
===================================================================
--- trunk/src/components/autofill/core/browser/personal_data_manager_unittest.cc (revision 282777)
+++ trunk/src/components/autofill/core/browser/personal_data_manager_unittest.cc (working copy)
@@ -2339,19 +2339,9 @@
base::MessageLoop::current()->Run();
AutofillProfile expected(base::GenerateGUID(), "https://www.example.com");
- test::SetProfileInfo(&expected,
- "George",
- NULL,
- "Washington",
- "theprez@gmail.com",
- NULL,
- "21 Laussat St",
- NULL,
- "San Francisco",
- "California",
- "94102",
- NULL,
- "817-555-6789");
+ test::SetProfileInfo(&expected, "George", NULL,
+ "Washington", "theprez@gmail.com", NULL, "21 Laussat St", NULL,
+ "San Francisco", "California", "94102", NULL, "(817) 555-6789");
const std::vector<AutofillProfile*>& results1 = personal_data_->GetProfiles();
ASSERT_EQ(1U, results1.size());
EXPECT_EQ(0, expected.Compare(*results1[0]));
@@ -2396,7 +2386,7 @@
// Modify expected to include multi-valued fields.
std::vector<base::string16> values;
expected.GetRawMultiInfo(PHONE_HOME_WHOLE_NUMBER, &values);
- values.push_back(ASCIIToUTF16("214-555-1234"));
+ values.push_back(ASCIIToUTF16("(214) 555-1234"));
expected.SetRawMultiInfo(PHONE_HOME_WHOLE_NUMBER, values);
ASSERT_EQ(1U, results2.size());
« no previous file with comments | « trunk/src/chrome/browser/ui/autofill/data_model_wrapper.cc ('k') | trunk/src/components/autofill/core/browser/phone_number.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698