Issue 38293002: Explicit GC of strings to avoid test timeout.

Issue 38293002: Explicit GC of strings to avoid test timeout. (Closed)

Created:
7 years, 2 months ago by rune

Modified:
7 years, 1 month ago

Reviewers:
ojan

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Explicit GC of strings to avoid test timeout. The test file visited-link-hang.html creates millions of strings with length 1-1000000. That caused the giant-stylesheet-crash.html test to time out if the strings were still not garbage collected. Added explicit garbage collection to clean up after the visited-link-hang strings. Likewise, added explicit GC calls as a safety measure in the test that timed out. R=ojan@chromium.org BUG=305037 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160683

Patch Set 1 #

Patch Set 2 : Rebase on top of CRLF -> LF change. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	LayoutTests/fast/css/giant-stylesheet-crash.html	View	1	2 chunks	+11 lines, -1 line	0 comments	Download
	M	LayoutTests/fast/css/visited-link-hang.html	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm On Wed, Oct 23, 2013 at 2:50 PM, <rune@opera.com> wrote: > Reviewers: ojan, > ...

7 years, 2 months ago (2013-10-23 23:12:48 UTC) #2

lgtm


On Wed, Oct 23, 2013 at 2:50 PM, <rune@opera.com> wrote:

> Reviewers: ojan,
>
> Description:
> Explicit GC of strings to avoid test timeout.
>
> The test file visited-link-hang.html creates millions of strings with
> length
> 1-1000000. That caused the giant-stylesheet-crash.html test to time out if
> the strings were still not garbage collected. Added explicit garbage
> collection to clean up after the visited-link-hang strings. Likewise, added
> explicit GC calls as a safety measure in the test that timed out.
>
> R=ojan@chromium.org
> BUG=305037
>
> Please review this at
https://codereview.chromium.**org/38293002/<https://codereview.chromium.org/3...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/blink.git@master<https://chromiu...
>
> Affected files (+19, -2 lines):
>   LayoutTests/fast/css/giant-**stylesheet-crash.html
>   LayoutTests/fast/css/visited-**link-hang.html
>
>
> Index: LayoutTests/fast/css/giant-**stylesheet-crash.html
> diff --git a/LayoutTests/fast/css/giant-**stylesheet-crash.html
> b/LayoutTests/fast/css/giant-**stylesheet-crash.html
> index 0a62f0d603c3dcf878d58008182046**f941a7eed1..**
> d800a023a8453af6966fa410fbb00a**0ee92ebb5c 100644
> --- a/LayoutTests/fast/css/giant-**stylesheet-crash.html
> +++ b/LayoutTests/fast/css/giant-**stylesheet-crash.html
> @@ -1,5 +1,9 @@
>  <head>
>  <script>
> +// GC unreferenced strings to avoid that this test times out.
> +if (window.GCController)
> +    GCController.collect();
> +
>  if (window.testRunner)
>      testRunner.dumpAsText();
>  </script>
> @@ -17,7 +21,13 @@ for (var i = 0; i < 1+(1<<16); i++){
>      styleElement.appendChild(txt);
>  }
>
> -document.**getElementsByTagName('head')[**0].appendChild(styleElement);
> +str = null;
> +
> +// GC the large str strings to avoid timeouts for subsequent tests.
> +if (window.GCController)
> +    GCController.collect();
> +
> +document.**getElementsByTagName('head')[**0].appendChild(styleElement);
>  </script>
>  </head>
>  <body>
> Index: LayoutTests/fast/css/visited-**link-hang.html
> diff --git a/LayoutTests/fast/css/**visited-link-hang.html
> b/LayoutTests/fast/css/**visited-link-hang.html
> index cd7d9dabc23aa475fc39ed7765f862**33d25fa57c..**
> 178d97db0162f279036ab72f50d7ac**599c1b068c 100644
> --- a/LayoutTests/fast/css/**visited-link-hang.html
> +++ b/LayoutTests/fast/css/**visited-link-hang.html
> @@ -25,6 +25,13 @@ document.getElementById("**test1").innerHTML = '<a
> href="about:test?slashes' + one
>  document.getElementById("**test2").innerHTML = '<a
> href="about:test?slashes' + oneMillionSlashesAndDots + '">Link with tons of
> slashes with dots</a>';
>  document.getElementById("**test3").innerHTML = '<a
> href="about:test?slashes' + oneMillionSlashesAndDoubleDots + '">Link with
> tons of slashes with double dots</a>';
>
> -document.getElementById("**result").firstChild.data = "TEST PASSED";
> +// GC these large strings so that they don't cause the next test to
> timeout.
> +if (window.GCController) {
> +    oneMillionSlashes = null;
> +    oneMillionSlashesAndDots = null;
> +    oneMillionSlashesAndDoubleDots = null;
> +    GCController.collect();
> +}
>
> +document.getElementById("**result").firstChild.data = "TEST PASSED";
>  </script>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.