LayoutTests/fast/css/giant-stylesheet-crash.html - Issue 38293002: Explicit GC of strings to avoid test timeout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css/giant-stylesheet-crash.html

Issue 38293002: Explicit GC of strings to avoid test timeout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on top of CRLF -> LF change. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/css/giant-stylesheet-crash.html

diff --git a/LayoutTests/fast/css/giant-stylesheet-crash.html b/LayoutTests/fast/css/giant-stylesheet-crash.html

index b450a88fc6cea0618457f914306733fe258df985..08c75cb9a9f030ad0b539ade5188af2c7afe8e42 100644

--- a/LayoutTests/fast/css/giant-stylesheet-crash.html

+++ b/LayoutTests/fast/css/giant-stylesheet-crash.html

@@ -1,5 +1,9 @@

<head>

+// GC unreferenced strings to avoid that this test times out.

+if (window.GCController)

+ GCController.collect();

if (window.testRunner)

testRunner.dumpAsText();

</script>

@@ -17,7 +21,13 @@ for (var i = 0; i < 1+(1<<16); i++){

styleElement.appendChild(txt);

}

-document.getElementsByTagName('head')[0].appendChild(styleElement);

+str = null;

+// GC the large str strings to avoid timeouts for subsequent tests.

+if (window.GCController)

+ GCController.collect();

+document.getElementsByTagName('head')[0].appendChild(styleElement);

</script>

</head>

<body>

« no previous file with comments | « no previous file | LayoutTests/fast/css/visited-link-hang.html » ('j') | no next file with comments »