Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382913002: Revert 282159 "athena: Move athena_export.h into common/ directory." (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282159 "athena: Move athena_export.h into common/ directory." Reason: My TODO was wrong. export.h should stay in athena/. > athena: Move athena_export.h into common/ directory. > > Fix a TODO in athena.gyp. > > BUG=None > TEST=None > R=oshima@chromium.org > > Review URL: https://codereview.chromium.org/371573002 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -54 lines) Patch
M trunk/src/athena/activity/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/activity/public/activity.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/activity/public/activity_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/activity/public/activity_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/activity/public/activity_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/activity/public/activity_view_model.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/athena.gyp View 1 chunk +2 lines, -1 line 0 comments Download
A + trunk/src/athena/athena_export.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/athena/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D trunk/src/athena/common/athena_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M trunk/src/athena/common/fill_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/content/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/content/public/content_activity_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/home/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/home/public/app_model_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/home/public/home_card.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/input/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/input/public/accelerator_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/input/public/input_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/screen/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/screen/public/screen_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/virtual_keyboard/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/virtual_keyboard/public/virtual_keyboard_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/virtual_keyboard/public/virtual_keyboard_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/wm/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/athena/wm/public/window_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
6 years, 5 months ago (2014-07-10 19:23:42 UTC) #1
oshima
Committed patchset #1 manually as r282394.
6 years, 5 months ago (2014-07-10 19:23:53 UTC) #2
tfarina
6 years, 5 months ago (2014-07-11 00:53:19 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698