Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 371573002: athena: Move athena_export.h into common/ directory. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam, Jun Mukai, Ben Goodger (Google)
Project:
chromium
Visibility:
Public.

Description

athena: Move athena_export.h into common/ directory. Fix a TODO in athena.gyp. BUG=None TEST=None R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -60 lines) Patch
M athena/activity/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_view_model.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/athena.gyp View 1 chunk +1 line, -2 lines 0 comments Download
D athena/athena_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M athena/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + athena/common/athena_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
M athena/common/fill_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/public/content_activity_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/public/app_model_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/public/home_card.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/input/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/input/public/accelerator_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/input/public/input_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/screen/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/screen/public/screen_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/virtual_keyboard/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/virtual_keyboard/public/virtual_keyboard_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/virtual_keyboard/public/virtual_keyboard_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/public/window_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 5 months ago (2014-07-04 01:47:52 UTC) #1
oshima
rubberstamp lgtm
6 years, 5 months ago (2014-07-07 21:20:37 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-09 22:10:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/371573002/1
6 years, 5 months ago (2014-07-09 22:12:36 UTC) #4
commit-bot: I haz the power
Change committed as 282159
6 years, 5 months ago (2014-07-09 23:01:26 UTC) #5
oshima
6 years, 5 months ago (2014-07-10 16:04:29 UTC) #6
Message was sent while issue was closed. 
On 2014/07/09 23:01:26, I haz the power (commit-bot) wrote:
> Change committed as 282159

My apologies, I think we need to keep it in athena/ (at least not in common) so
that we can limit the use of
export only in public. I'll revert this. It was my mistake and I'm very sorry
about that.

Powered by Google App Engine
This is Rietveld 408576698