Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: scripts/slave/recipe_modules/gclient/config.py

Issue 382903002: Fix Deps for android/perf recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Update solutions to be non-managed (noop in bot_update) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/gclient/config.py
diff --git a/scripts/slave/recipe_modules/gclient/config.py b/scripts/slave/recipe_modules/gclient/config.py
index 83806e51f52f001ff8f6c1f8a810398209ba9d86..c5d85f2de78658a6eddfbedd3bec16c8bd651768 100644
--- a/scripts/slave/recipe_modules/gclient/config.py
+++ b/scripts/slave/recipe_modules/gclient/config.py
@@ -317,3 +317,24 @@ def tools_build(c):
s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git')
m = c.got_revision_mapping
m['build'] = 'got_revision'
+
+@config_ctx(includes=['chromium', 'chrome_internal'])
+def perf(c):
+ s = c.solutions[0]
+ s.custom_vars['llvm_url'] = 'svn://svn-mirror.golo.chromium.org/llvm-project'
+ s.custom_deps.update({
tonyg 2014/07/10 19:47:31 Let's add a comment noting that these are removed
zty 2014/07/10 20:29:08 Done.
+ 'src/chrome/test/data/pdf_private': None,
+ 'src/third_party/WebKit/LayoutTests': None,
+ 'src/tools/valgrind': None,
+ })
+ s.managed = False
tonyg 2014/07/10 19:47:31 I'm curious what this does.
zty 2014/07/10 20:29:08 "managed" is a property on gclient solutions. If i
+ needed_components_internal = [
+ "src/chrome/test/data/perf/frame_rate/private",
+ "src/chrome/test/data/plugin",
+ "src/data/memory_test",
+ "src/data/page_cycler",
tonyg 2014/07/10 19:47:31 I *think* this is the only one we actually need. E
+ "src/data/tab_switching",
+ ]
+ for key in needed_components_internal:
+ del c.solutions[1].custom_deps[key]
+ c.solutions[1].managed = False
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698