Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Side by Side Diff: scripts/slave/recipe_modules/gclient/config.py

Issue 382903002: Fix Deps for android/perf recipe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Update solutions to be non-managed (noop in bot_update) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import types 5 import types
6 6
7 from slave.recipe_config import config_item_context, ConfigGroup, BadConf 7 from slave.recipe_config import config_item_context, ConfigGroup, BadConf
8 from slave.recipe_config import ConfigList, Dict, Single, Static, Set, List 8 from slave.recipe_config import ConfigList, Dict, Single, Static, Set, List
9 9
10 def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None, **_kwargs): 10 def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None, **_kwargs):
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 310
311 @config_ctx(config_vars={'GIT_MODE': True}) 311 @config_ctx(config_vars={'GIT_MODE': True})
312 def tools_build(c): 312 def tools_build(c):
313 if not c.GIT_MODE: 313 if not c.GIT_MODE:
314 raise BadConf('tools_build only supports git') 314 raise BadConf('tools_build only supports git')
315 s = c.solutions.add() 315 s = c.solutions.add()
316 s.name = 'build' 316 s.name = 'build'
317 s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git') 317 s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git')
318 m = c.got_revision_mapping 318 m = c.got_revision_mapping
319 m['build'] = 'got_revision' 319 m['build'] = 'got_revision'
320
321 @config_ctx(includes=['chromium', 'chrome_internal'])
322 def perf(c):
323 s = c.solutions[0]
324 s.custom_vars['llvm_url'] = 'svn://svn-mirror.golo.chromium.org/llvm-project'
325 s.custom_deps.update({
tonyg 2014/07/10 19:47:31 Let's add a comment noting that these are removed
zty 2014/07/10 20:29:08 Done.
326 'src/chrome/test/data/pdf_private': None,
327 'src/third_party/WebKit/LayoutTests': None,
328 'src/tools/valgrind': None,
329 })
330 s.managed = False
tonyg 2014/07/10 19:47:31 I'm curious what this does.
zty 2014/07/10 20:29:08 "managed" is a property on gclient solutions. If i
331 needed_components_internal = [
332 "src/chrome/test/data/perf/frame_rate/private",
333 "src/chrome/test/data/plugin",
334 "src/data/memory_test",
335 "src/data/page_cycler",
tonyg 2014/07/10 19:47:31 I *think* this is the only one we actually need. E
336 "src/data/tab_switching",
337 ]
338 for key in needed_components_internal:
339 del c.solutions[1].custom_deps[key]
340 c.solutions[1].managed = False
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698