Fix Deps for android/perf recipe.

Fix Deps for android/perf recipe.

Gclient Solutions
=================
src (https://chromium.googlesource.com/chromium/src.git)
  Dependencies file is .DEPS.git
  Managed mode is OFF
  Custom Variables:
    googlecode_url = svn://svn-mirror.golo.chromium.org/%s
    llvm_url = svn://svn-mirror.golo.chromium.org/llvm-project
    nacl_trunk = svn://svn-mirror.golo.chromium.org/native_client/trunk
    sourceforge_url = svn://svn-mirror.golo.chromium.org/%(repo)s
    webkit_trunk = svn://svn-mirror.golo.chromium.org/blink/trunk
  Custom Dependencies:
    src/chrome/test/data/pdf_private: Ignore
    src/third_party/WebKit/LayoutTests: Ignore
    src/tools/valgrind: Ignore

src-internal (https://chrome-internal.googlesource.com/chrome/src-internal.git)
  Dependencies file is .DEPS.git
  Managed mode is OFF
  Custom Dependencies:
    src/chrome/test/data/firefox2_profile/searchplugins: Ignore
    src/chrome/test/data/firefox2_searchplugins: Ignore
    src/chrome/test/data/firefox3_profile/searchplugins: Ignore
    src/chrome/test/data/firefox3_searchplugins: Ignore
    src/chrome/test/data/osdd: Ignore
    src/chrome/test/data/ssl/certs: Ignore
    src/data/autodiscovery: Ignore
    src/data/esctf: Ignore
    src/data/mach_ports: Ignore
    src/data/mozilla_js_tests: Ignore
    src/data/selenium_core: Ignore
    src/tools/grit/grit/test/data: Ignore
    src/webkit/data/bmp_decoder: Ignore
    src/webkit/data/ico_decoder: Ignore
    src/webkit/data/test_shell/plugins: Ignore
    src/webkit/data/xbm_decoder: Ignore

BUG=392487
R=tonyg@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=282423

[zty, 2014-07-10 19:24:56]

ptal

[tonyg, 2014-07-10 19:47:31]

lgtm

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/gclient/config.py:325: s.custom_deps.update({
Let's add a comment noting that these are removed because they're large and the
perf bots don't need them.

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/gclient/config.py:330: s.managed = False
I'm curious what this does.

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/gclient/config.py:335: "src/data/page_cycler",
I *think* this is the only one we actually need. Eventually I'd like to get rid
of all these src-internal deps, so maybe eliminate the others unless we find
that we need them?

[zty, 2014-07-10 20:29:08]

addressed.

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/gclient/config.py:325: s.custom_deps.update({
On 2014/07/10 19:47:31, tonyg wrote:
> Let's add a comment noting that these are removed because they're large and
the
> perf bots don't need them.

Done.

https://codereview.chromium.org/382903002/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/gclient/config.py:330: s.managed = False
"managed" is a property on gclient solutions. If it is set to True, gclient sync
would attempt to do git pull --rebase. Otherwise, it blows up all the local
changes. managed=True is considered evil and is going away. If bot_update is
enabled, managed is always False. Hence the noop here. But I would like it to be
explicit.
On 2014/07/10 19:47:31, tonyg wrote:
> I'm curious what this does.

[zty, 2014-07-10 20:30:03]

The CQ bit was checked by zty@chromium.org

[commit-bot: I haz the power, 2014-07-10 20:30:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zty@chromium.org/382903002/40001

[commit-bot: I haz the power, 2014-07-10 20:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 20:31:20]

Presubmit check for 382903002-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    build/scripts/slave/recipe_modules/gclient/config.py

Presubmit checks took 53.8s to calculate.

[zty, 2014-07-10 20:31:58]

Added hinoka for owner lgtm

[Ryan Tseng, 2014-07-10 20:37:38]

Can you be more explicit what the change is and what its fixing? afaik
pdf_private isn't a part of src/ and adding the 3 ignores into the src solution
should be no-ops because none of them are top level DEPS repos (they're
subfolders at best, so the directives are ignored).

[zty, 2014-07-10 20:39:55]

The change is to make the recipe version of perf builders checkout the same
source tree as the non recipe one.
The non-recipe gclient solution is stated in the description.

On 2014/07/10 20:37:38, Ryan T. wrote:
> Can you be more explicit what the change is and what its fixing? afaik
> pdf_private isn't a part of src/ and adding the 3 ignores into the src
solution
> should be no-ops because none of them are top level DEPS repos (they're
> subfolders at best, so the directives are ignored).

[Ryan Tseng, 2014-07-10 20:44:32]

lgtm

[zty, 2014-07-10 20:44:56]

The CQ bit was checked by zty@chromium.org

[commit-bot: I haz the power, 2014-07-10 20:45:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zty@chromium.org/382903002/40001

[commit-bot: I haz the power, 2014-07-10 20:46:27]

Change committed as 282423