Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 382673003: Revert of Update smoothness_controller to use results.AddValue(...) (Closed)

Created:
6 years, 5 months ago by dgrogan
Modified:
6 years, 5 months ago
Reviewers:
nednguyen, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update smoothness_controller to use results.AddValue(...) (https://codereview.chromium.org/380803002/) Reason for revert: Possibly caused Android Tests failures. See http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14520/steps/telemetry_perf_unittests/logs/stdio E.g. Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:534 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:247 self.ValidatePage(page, tab, results) ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60 self.MeasurePage(page, tab, results) MeasurePage at tools/perf/measurements/smoothness.py:36 self._smoothness_controller.AddResults(tab, results) AddResults at tools/perf/measurements/smoothness_controller.py:100 results.current_page, r.name, r.unit, r.value)) __init__ at tools/telemetry/telemetry/value/scalar.py:19 assert isinstance(value, numbers.Number) AssertionError Original issue's description: > Update smoothness_controller to use results.AddValue(...) > > BUG=391943 > TBR=nduca@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131 TBR=nduca@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=391943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/perf/measurements/smoothness_controller.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrogan
Created Revert of Update smoothness_controller to use results.AddValue(...)
6 years, 5 months ago (2014-07-09 22:57:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/382673003/1
6 years, 5 months ago (2014-07-09 23:01:45 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 23:21:02 UTC) #3
Message was sent while issue was closed.
Change committed as 282170

Powered by Google App Engine
This is Rietveld 408576698