tools/perf/measurements/smoothness_controller.py - Issue 382673003: Revert of Update smoothness_controller to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_controller.py

Issue 382673003: Revert of Update smoothness_controller to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness_controller.py

diff --git a/tools/perf/measurements/smoothness_controller.py b/tools/perf/measurements/smoothness_controller.py

index 4d0f37ff1a9a1cbd59329fa8941560699f814c1d..3bcd285bf5a810ac0f41c3590e3e41a8ec670c84 100644

--- a/tools/perf/measurements/smoothness_controller.py

+++ b/tools/perf/measurements/smoothness_controller.py

@@ -9,7 +9,6 @@

from telemetry.page.actions import action_runner

from telemetry.web_perf import timeline_interaction_record as tir_module

from telemetry.web_perf.metrics import smoothness

-from telemetry.value import scalar

RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'

@@ -96,8 +95,7 @@

for r in tab.browser.platform.GetRawDisplayFrameRateMeasurements():

if r.value is None:

raise MissingDisplayFrameRateError(r.name)

- results.AddValue(scalar.ScalarValue(

- results.current_page, r.name, r.unit, r.value))

+ results.Add(r.name, r.unit, r.value)

def CleanUp(self, tab):

if tab.browser.platform.IsRawDisplayFrameRateSupported():

« no previous file with comments | « no previous file | no next file » | no next file with comments »