Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382663002: Add components and CLD to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, jam, Ilya Sherman, asvitkine+watch_chromium.org, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add components and CLD to GN build. New components: - rappor - data_reduction_proxy - captive_portal - translate - usb_service - web_modal Removes the _IMPLEMENTATION define for web_modal. It is unused (it is a static library, not a component). Adds third_party/cld and third_party/cld_2 BUILD files. Separates out the include dir setting of "//" and the root gen directory so. cld_2 needed to not have this due to base file name conflicts. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282438

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -124 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/BUILD.gn View 1 3 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 chunks +12 lines, -12 lines 0 comments Download
M components/BUILD.gn View 4 chunks +23 lines, -3 lines 0 comments Download
M components/autocomplete.gypi View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
A components/autocomplete/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download
M components/captive_portal.gypi View 4 chunks +4 lines, -0 lines 0 comments Download
A components/captive_portal/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download
M components/data_reduction_proxy.gypi View 6 chunks +6 lines, -0 lines 0 comments Download
A components/data_reduction_proxy/browser/BUILD.gn View 1 chunk +52 lines, -0 lines 0 comments Download
A + components/data_reduction_proxy/common/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 1 1 chunk +5 lines, -1 line 0 comments Download
M components/rappor.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
A components/rappor/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A + components/rappor/proto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/translate.gypi View 12 chunks +12 lines, -0 lines 0 comments Download
M components/translate/BUILD.gn View 1 1 chunk +0 lines, -72 lines 0 comments Download
A components/translate/content/browser/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
A components/translate/content/common/BUILD.gn View 1 chunk +27 lines, -0 lines 0 comments Download
A components/translate/content/renderer/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
A components/translate/core/browser/BUILD.gn View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A components/translate/core/common/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A components/translate/core/language_detection/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
M components/usb_service.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/usb_service/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
M components/web_modal.gypi View 3 chunks +4 lines, -3 lines 0 comments Download
A components/web_modal/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/cld/BUILD.gn View 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/cld_2/BUILD.gn View 1 chunk +147 lines, -0 lines 0 comments Download
M third_party/cld_2/cld_2.gyp View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 5 months ago (2014-07-09 22:04:23 UTC) #1
jamesr
lgtm https://codereview.chromium.org/382663002/diff/20001/components/translate/core/browser/BUILD.gn File components/translate/core/browser/BUILD.gn (right): https://codereview.chromium.org/382663002/diff/20001/components/translate/core/browser/BUILD.gn#newcode41 components/translate/core/browser/BUILD.gn:41: # TODO(brettw) move thise above. This project uses ...
6 years, 5 months ago (2014-07-09 22:21:57 UTC) #2
brettw
https://codereview.chromium.org/382663002/diff/20001/components/translate/core/browser/BUILD.gn File components/translate/core/browser/BUILD.gn (right): https://codereview.chromium.org/382663002/diff/20001/components/translate/core/browser/BUILD.gn#newcode41 components/translate/core/browser/BUILD.gn:41: # TODO(brettw) move thise above. This project uses net ...
6 years, 5 months ago (2014-07-10 18:18:58 UTC) #3
brettw
6 years, 5 months ago (2014-07-10 22:00:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r282438.

Powered by Google App Engine
This is Rietveld 408576698