Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: components/web_modal.gypi

Issue 382663002: Add components and CLD to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/usb_service/BUILD.gn ('k') | components/web_modal/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_modal.gypi
diff --git a/components/web_modal.gypi b/components/web_modal.gypi
index 356cb7eb6823064811d1e4f1369df292e80b41e7..25028034dea7db3118512477abf26c8aac5b5941 100644
--- a/components/web_modal.gypi
+++ b/components/web_modal.gypi
@@ -5,6 +5,7 @@
{
'targets': [
{
+ # GN version: //components/web_modal
'target_name': 'web_modal',
'type': 'static_library',
'include_dirs': [
@@ -15,10 +16,8 @@
'../content/content.gyp:content_browser',
'../skia/skia.gyp:skia',
],
- 'defines': [
- 'WEB_MODAL_IMPLEMENTATION',
- ],
'sources': [
+ # Note: sources list duplicated in GN build.
'web_modal/modal_dialog_host.cc',
'web_modal/modal_dialog_host.h',
'web_modal/native_web_contents_modal_dialog.h',
@@ -32,12 +31,14 @@
],
},
{
+ # GN version: //components/web_modal:test_support
'target_name': 'web_modal_test_support',
'type': 'static_library',
'dependencies': [
'web_modal',
],
'sources': [
+ # Note: sources list duplicated in GN build.
'web_modal/test_web_contents_modal_dialog_host.cc',
'web_modal/test_web_contents_modal_dialog_host.h',
'web_modal/test_web_contents_modal_dialog_manager_delegate.cc',
« no previous file with comments | « components/usb_service/BUILD.gn ('k') | components/web_modal/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698