Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 382583002: Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes (https://codereview.chromium.org/371933003/) Reason for revert: revert this as all related CLs are committed Original issue's description: > Disable another WebView fullscreen video test until we land fullscreen IPC changes > > there are 2 changes needs to be submitted before we reenable the tests: > 1. https://codereview.chromium.org/290643005/ and > 2. https://codereview.chromium.org/292573004/ > > the blink change will break all the tests, so we need to reenable the test after the chromium change lands > > BUG=367346 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281627 TBR=boliu@chromium.org BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qinmin
Created Revert of Disable another WebView fullscreen video test until we land fullscreen IPC changes
6 years, 5 months ago (2014-07-09 16:32:51 UTC) #1
boliu
dude you really want this one to sit through cq
6 years, 5 months ago (2014-07-09 16:34:12 UTC) #2
boliu
The CQ bit was unchecked by boliu@chromium.org
6 years, 5 months ago (2014-07-09 16:34:18 UTC) #3
boliu
On 2014/07/09 16:34:12, boliu wrote: > dude you really want this one to sit through ...
6 years, 5 months ago (2014-07-09 16:34:31 UTC) #4
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-09 16:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/382583002/1
6 years, 5 months ago (2014-07-09 16:47:32 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 20:30:21 UTC) #7
Message was sent while issue was closed.
Change committed as 282111

Powered by Google App Engine
This is Rietveld 408576698