Add a force-layout-height-to-zero layout mode to WebViewImpl

Add a force-layout-height-to-zero layout mode to WebViewImpl

This makes it possible for the android_webview to implement
'wrap_content' mode for the view's height without completely ignoring
the viewport meta tag (like it's doing now).

BUG=392460
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179705

[mkosiba (inactive), 2014-07-09 16:02:07]

PTAL. more context is in the bug, but I essentially want to deprecate
setFixedLayoutSize and use this instead.

[mnaganov (inactive), 2014-07-09 16:13:11]

https://codereview.chromium.org/382543003/diff/1/Source/web/tests/WebFrameTes...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/382543003/diff/1/Source/web/tests/WebFrameTes...
Source/web/tests/WebFrameTest.cpp:1402: EXPECT_EQ(0,
webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
Maybe it makes sense to disable the setting again and check that height is not 0
anymore? As currently you are only testing transition from 'false' to 'true'.

[abarth-chromium, 2014-07-09 17:01:08]

https://codereview.chromium.org/382543003/diff/1/public/web/WebView.h
File public/web/WebView.h (right):

https://codereview.chromium.org/382543003/diff/1/public/web/WebView.h#newcode293
public/web/WebView.h:293: virtual void setForceZeroLayoutHeight(bool enable) =
0;
This should be a WebSetting instead of being a member function of WebView.

[mkosiba (inactive), 2014-07-09 17:01:27]

https://codereview.chromium.org/382543003/diff/1/Source/web/tests/WebFrameTes...
File Source/web/tests/WebFrameTest.cpp (right):

https://codereview.chromium.org/382543003/diff/1/Source/web/tests/WebFrameTes...
Source/web/tests/WebFrameTest.cpp:1402: EXPECT_EQ(0,
webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
On 2014/07/09 16:13:11, Mikhail Naganov (Cr) wrote:
> Maybe it makes sense to disable the setting again and check that height is not
0
> anymore? As currently you are only testing transition from 'false' to 'true'.

Done.

[mkosiba (inactive), 2014-07-09 17:14:24]

https://codereview.chromium.org/382543003/diff/1/public/web/WebView.h
File public/web/WebView.h (right):

https://codereview.chromium.org/382543003/diff/1/public/web/WebView.h#newcode293
public/web/WebView.h:293: virtual void setForceZeroLayoutHeight(bool enable) =
0;
On 2014/07/09 17:01:07, abarth wrote:
> This should be a WebSetting instead of being a member function of WebView.

I wanted to do that but I couldn't find a way to trigger a recalculation of the
viewport (which takes place in WebViewImpl) from WebSettings. The embedding
application can go in and out of this mode and when this is toggled I need to
force the layoutSize to be recalculated and set on the FrameView.

[abarth-chromium, 2014-07-10 03:02:39]

Lots of web settings cause invalidations.  See, for example, all the
"invalidate=Style" settings in Settings.in

[mkosiba (inactive), 2014-07-25 08:52:20]

On 2014/07/10 03:02:39, abarth wrote:
> Lots of web settings cause invalidations.  See, for example, all the
> "invalidate=Style" settings in Settings.in

Done. PTAL!

[mkosiba (inactive), 2014-07-28 17:13:44]

ping?

[mkosiba (inactive), 2014-07-29 16:32:38]

ping

[mnaganov (inactive), 2014-07-29 16:34:14]

LGTM to get the ball rolling

[abarth-chromium, 2014-07-29 16:54:55]

https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:3053: layoutSize.height = 0;
The settings machinery looks fine, but I don't understand the consequences of
this part of the CL.  We'll need to get someone who understands this line to
complete the review.

[mkosiba (inactive), 2014-07-29 16:57:43]

https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:3053: layoutSize.height = 0;
On 2014/07/29 16:54:55, abarth wrote:
> The settings machinery looks fine, but I don't understand the consequences of
> this part of the CL.  We'll need to get someone who understands this line to
> complete the review.

Thanks! I'll ask Alex to take a look.

[mkosiba (inactive), 2014-07-29 19:42:50]

On 2014/07/29 16:57:43, mkosiba wrote:
>
https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.cpp
> File Source/web/WebViewImpl.cpp (right):
> 
>
https://codereview.chromium.org/382543003/diff/40001/Source/web/WebViewImpl.c...
> Source/web/WebViewImpl.cpp:3053: layoutSize.height = 0;
> On 2014/07/29 16:54:55, abarth wrote:
> > The settings machinery looks fine, but I don't understand the consequences
of
> > this part of the CL.  We'll need to get someone who understands this line to
> > complete the review.
> 
> Thanks! I'll ask Alex to take a look.

-aelias@google.com
+aelias@chromium.org

[aelias_OOO_until_Jul13, 2014-07-29 21:26:12]

lgtm.  This is just a simpler and less invasive variant of setFixedLayoutSize. 
We already know 0 height doesn't lead to any particular breakage from our
experience with setting 0 height via that mechanism.

[abarth-chromium, 2014-07-29 21:57:15]

lgtm2 then

[mkosiba (inactive), 2014-08-07 12:18:33]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-08-07 12:19:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkosiba@chromium.org/382543003/80001

[commit-bot: I haz the power, 2014-08-07 13:43:32]

Change committed as 179705

[jbroman, 2014-08-07 14:19:52]

A revert of this CL has been created in
https://codereview.chromium.org/451633004/ by jbroman@chromium.org.

The reason for reverting is: Breaks WebKit Android (Nexus4)
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Ne...

C   75.423s Main  [FAIL] WebFrameTest.SetForceZeroLayoutHeight:
C   75.423s Main 
../../third_party/WebKit/Source/web/tests/WebFrameTest.cpp:1396: Failure
C   75.423s Main  Value of:
webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height()
C   75.423s Main    Actual: 735
C   75.423s Main  Expected: viewportHeight
C   75.423s Main  Which is: 480.