Issue 382463002: Add a check that we make progress during incremental marking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382463002: Add a check that we make progress during incremental marking (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add a check that we make progress during incremental marking BUG=381820 R=hpayer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22294

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/incremental-marking.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, one nit https://codereview.chromium.org/382463002/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): https://codereview.chromium.org/382463002/diff/1/src/incremental-marking.cc#newcode704 src/incremental-marking.cc:704: CHECK(0 < delta && delta <= ...

6 years, 5 months ago (2014-07-09 08:53:49 UTC) #2

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-07-09 09:17:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22294 (presubmit successful).

Expand Messages | Collapse Messages