Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: src/incremental-marking.cc

Issue 382463002: Add a check that we make progress during incremental marking (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/incremental-marking.cc
diff --git a/src/incremental-marking.cc b/src/incremental-marking.cc
index f9575c3ba433393d67990a5edd45d08610c7dfeb..7dd687cce1a52ac96d010974e41d039f79af2e0d 100644
--- a/src/incremental-marking.cc
+++ b/src/incremental-marking.cc
@@ -699,7 +699,10 @@ void IncrementalMarking::ProcessMarkingDeque(intptr_t bytes_to_process) {
int size = obj->SizeFromMap(map);
unscanned_bytes_of_large_object_ = 0;
VisitObject(map, obj, size);
- bytes_to_process -= (size - unscanned_bytes_of_large_object_);
+ int delta = (size - unscanned_bytes_of_large_object_);
+ // FIXME: remove after http://crbug.com/381820 is resolved.
+ CHECK(0 < delta && delta <= bytes_to_process);
Hannes Payer (out of office) 2014/07/09 08:53:49 delta can be larger than bytes_to_process. I guess
+ bytes_to_process -= delta;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698