Chromium Code Reviews| Index: chrome/common/logging_chrome.cc |
| diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc |
| index adca73734a85772e04cc5cd6dc42f707e51a4fa9..b21ee27369f89f0d82ee4a11e5a26970b0b38260 100644 |
| --- a/chrome/common/logging_chrome.cc |
| +++ b/chrome/common/logging_chrome.cc |
| @@ -52,6 +52,7 @@ |
| #include "ipc/ipc_logging.h" |
| #if defined(OS_CHROMEOS) |
| +#include "base/sys_info.h" |
| #include "chromeos/chromeos_switches.h" |
| #endif |
| @@ -239,8 +240,10 @@ void RedirectChromeLogging(const CommandLine& command_line) { |
| settings.logging_dest = DetermineLogMode(command_line); |
| settings.log_file = log_path.value().c_str(); |
| if (!logging::InitLogging(settings)) { |
| - DLOG(ERROR) << "Unable to initialize logging to " << log_path.value(); |
| - RemoveSymlinkAndLog(log_path, target_path); |
|
sky
2014/07/11 23:33:24
Do we always want to remove the symlink?
stevenjb
2014/07/14 17:20:32
Maybe? I think I am going to leave this as it was,
|
| + if (base::SysInfo::IsRunningOnChromeOS()) { |
| + DLOG(ERROR) << "Unable to initialize logging to " << log_path.value(); |
| + RemoveSymlinkAndLog(log_path, target_path); |
| + } |
| } else { |
| chrome_logging_redirected_ = true; |
| } |