Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4877)

Unified Diff: chrome/common/logging_chrome.cc

Issue 382403002: Reduce log spam for linux-chromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/settings/owner_key_util.cc ('k') | chromeos/network/host_resolver_impl_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc
index adca73734a85772e04cc5cd6dc42f707e51a4fa9..b21ee27369f89f0d82ee4a11e5a26970b0b38260 100644
--- a/chrome/common/logging_chrome.cc
+++ b/chrome/common/logging_chrome.cc
@@ -52,6 +52,7 @@
#include "ipc/ipc_logging.h"
#if defined(OS_CHROMEOS)
+#include "base/sys_info.h"
#include "chromeos/chromeos_switches.h"
#endif
@@ -239,8 +240,10 @@ void RedirectChromeLogging(const CommandLine& command_line) {
settings.logging_dest = DetermineLogMode(command_line);
settings.log_file = log_path.value().c_str();
if (!logging::InitLogging(settings)) {
- DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
- RemoveSymlinkAndLog(log_path, target_path);
sky 2014/07/11 23:33:24 Do we always want to remove the symlink?
stevenjb 2014/07/14 17:20:32 Maybe? I think I am going to leave this as it was,
+ if (base::SysInfo::IsRunningOnChromeOS()) {
+ DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
+ RemoveSymlinkAndLog(log_path, target_path);
+ }
} else {
chrome_logging_redirected_ = true;
}
« no previous file with comments | « chrome/browser/chromeos/settings/owner_key_util.cc ('k') | chromeos/network/host_resolver_impl_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698