Reduce log spam for linux-chromeos

chrome/common/logging_chrome.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 // Need to include this before most other files because it defines
 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
 // IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the
 // ViewMsgLog et al. functions.
@@ skipping 34 matching lines @@
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time/time.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/env_vars.h"
 #include "ipc/ipc_logging.h"
 
 #if defined(OS_CHROMEOS)
+#include "base/sys_info.h"
 #include "chromeos/chromeos_switches.h"
 #endif
 
 #if defined(OS_WIN)
 #include <initguid.h>
 #include "base/logging_win.h"
 #endif
 
 namespace {
 
@@ skipping 167 matching lines @@
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   // Always force a new symlink when redirecting.
   base::FilePath target_path = SetUpSymlinkIfNeeded(log_path, true);
 
   // ChromeOS always logs through the symlink, so it shouldn't be
   // deleted if it already exists.
   logging::LoggingSettings settings;
   settings.logging_dest = DetermineLogMode(command_line);
   settings.log_file = log_path.value().c_str();
   if (!logging::InitLogging(settings)) {
-    DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
-    RemoveSymlinkAndLog(log_path, target_path);

[sky, 2014/07/11 23:33:24]

Do we always want to remove the symlink?

[stevenjb, 2014/07/14 17:20:32]

Maybe? I think I am going to leave this as it was, it's only one line, and
probably not a bad idea to point out that logging is not in the "usual" place,
whatever that is for linux-chromeos. (It might be worth fixing properly at some
point, but not here).

+    if (base::SysInfo::IsRunningOnChromeOS()) {
+      DLOG(ERROR) << "Unable to initialize logging to " << log_path.value();
+      RemoveSymlinkAndLog(log_path, target_path);
+    }
   } else {
     chrome_logging_redirected_ = true;
   }
 }
 
 #endif  // OS_CHROMEOS
 
 void InitChromeLogging(const CommandLine& command_line,
                        OldFileDeletionState delete_old_log_file) {
   DCHECK(!chrome_logging_initialized_) <<
@@ skipping 170 matching lines @@
                                           time_deets.year,
                                           time_deets.month,
                                           time_deets.day_of_month,
                                           time_deets.hour,
                                           time_deets.minute,
                                           time_deets.second);
   return base_path.InsertBeforeExtensionASCII(suffix);
 }
 
 }  // namespace logging