Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 382403002: Reduce log spam for linux-chromeos (Closed)

Created:
6 years, 5 months ago by stevenjb
Modified:
6 years, 5 months ago
Reviewers:
eroman, ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reduce log spam for linux-chromeos BUG=393266 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284722

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert logging_chrome change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/chromeos/settings/owner_key_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/network/host_resolver_impl_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stevenjb
This just eliminates some unhelpful log spam when running linux-chromeos. sky@ - chrome/common OWNER
6 years, 5 months ago (2014-07-11 23:27:56 UTC) #1
sky
https://codereview.chromium.org/382403002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (left): https://codereview.chromium.org/382403002/diff/1/chrome/common/logging_chrome.cc#oldcode243 chrome/common/logging_chrome.cc:243: RemoveSymlinkAndLog(log_path, target_path); Do we always want to remove the ...
6 years, 5 months ago (2014-07-11 23:33:24 UTC) #2
stevenjb
https://codereview.chromium.org/382403002/diff/1/chrome/common/logging_chrome.cc File chrome/common/logging_chrome.cc (left): https://codereview.chromium.org/382403002/diff/1/chrome/common/logging_chrome.cc#oldcode243 chrome/common/logging_chrome.cc:243: RemoveSymlinkAndLog(log_path, target_path); On 2014/07/11 23:33:24, sky wrote: > Do ...
6 years, 5 months ago (2014-07-14 17:20:32 UTC) #3
sky
This means you no longer need me to review: -sky
6 years, 5 months ago (2014-07-14 20:45:46 UTC) #4
stevenjb
ptal
6 years, 5 months ago (2014-07-16 20:00:23 UTC) #5
ygorshenin1
lgtm
6 years, 5 months ago (2014-07-22 13:30:06 UTC) #6
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 5 months ago (2014-07-22 15:45:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/382403002/20001
6 years, 5 months ago (2014-07-22 15:46:34 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 17:43:31 UTC) #9
Message was sent while issue was closed.
Change committed as 284722

Powered by Google App Engine
This is Rietveld 408576698