Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382373002: Add CanAccessToolchainBucket() to ways to use GStorage. (Closed)

Created:
6 years, 5 months ago by liamjm (20p)
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Add CanAccessToolchainBucket() to ways to use GStorage. This allows Googlers who didn't pass existing checks to use G storage and the Pro version of Visual studio. BUG= TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=283250

Patch Set 1 #

Patch Set 2 : Fix column width error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
liamjm (20p)
Scott, As discussed the other week. Works in my testing.
6 years, 5 months ago (2014-07-11 21:37:34 UTC) #1
scottmg
lgtm
6 years, 5 months ago (2014-07-11 22:48:39 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-15 20:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/liamjm@chromium.org/382373002/10002
6 years, 5 months ago (2014-07-15 20:29:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 20:30:59 UTC) #5
commit-bot: I haz the power
Presubmit check for 382373002-10002 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-07-15 20:31:00 UTC) #6
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-15 20:35:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/liamjm@chromium.org/382373002/10002
6 years, 5 months ago (2014-07-15 20:35:59 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 20:37:54 UTC) #9
Message was sent while issue was closed. 
Change committed as 283250

Powered by Google App Engine
This is Rietveld 408576698