win_toolchain/get_toolchain_if_necessary.py - Issue 382373002: Add CanAccessToolchainBucket() to ways to use GStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/get_toolchain_if_necessary.py

Issue 382373002: Add CanAccessToolchainBucket() to ways to use GStorage. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fix column width error. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win_toolchain/get_toolchain_if_necessary.py

diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py

index dcf1125eb6ad92dd82544edca591e24ec22f6b4f..522a6972ea8b64a115d79f6c0030251af44ee2d8 100755

--- a/win_toolchain/get_toolchain_if_necessary.py

+++ b/win_toolchain/get_toolchain_if_necessary.py

@@ -224,7 +224,9 @@ def main():

current_hash = CalculateHash(target_dir)

if current_hash not in desired_hashes:

should_use_gs = False

- if HaveSrcInternalAccess() or LooksLikeGoogler():

+ if (HaveSrcInternalAccess() or

+ LooksLikeGoogler() or

+ CanAccessToolchainBucket()):

should_use_gs = True

if not CanAccessToolchainBucket():

RequestGsAuthentication()

« no previous file with comments | « no previous file | no next file » | no next file with comments »