Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 382213003: AutofillAgent cleanup: Removing two unused variables. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
benquan, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, jam, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

AutofillAgent cleanup: Removing two unused variables. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 2 chunks +0 lines, -7 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Mike West
These variables don't appear to be used; WDYT, Vaclav?
6 years, 5 months ago (2014-07-15 07:59:49 UTC) #1
vabr (Chromium)
If the compilers are happy, I'm happy (=LGTM). Disclaimer: I'm not an OWNER here, you ...
6 years, 5 months ago (2014-07-15 08:15:10 UTC) #2
Mike West
Ah, right. This is the other component. :) Hi Ilya. Mind taking a look?
6 years, 5 months ago (2014-07-15 08:16:20 UTC) #3
Mike West
Sorry, wrong Ilya. Hi Ilya! Mind taking a look? -mike
6 years, 5 months ago (2014-07-15 08:35:59 UTC) #4
vabr (Chromium)
(Looks like Ilya's e-mail in the review field got chewed by codereview's Javascript, so re-adding ...
6 years, 5 months ago (2014-07-15 08:37:33 UTC) #5
Ilya Sherman
LGTM, thanks!
6 years, 5 months ago (2014-07-15 17:58:56 UTC) #6
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-15 17:58:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/382213003/1
6 years, 5 months ago (2014-07-15 18:02:51 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 01:23:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:49:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170777)
6 years, 5 months ago (2014-07-16 01:49:21 UTC) #11
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-16 07:59:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/382213003/1
6 years, 5 months ago (2014-07-16 08:01:52 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:28:26 UTC) #14
Message was sent while issue was closed.
Change committed as 283442

Powered by Google App Engine
This is Rietveld 408576698