Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.h

Issue 382213003: AutofillAgent cleanup: Removing two unused variables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 // The ID of the last request sent for form field Autofill. Used to ignore 187 // The ID of the last request sent for form field Autofill. Used to ignore
188 // out of date responses. 188 // out of date responses.
189 int autofill_query_id_; 189 int autofill_query_id_;
190 190
191 // The element corresponding to the last request sent for form field Autofill. 191 // The element corresponding to the last request sent for form field Autofill.
192 blink::WebFormControlElement element_; 192 blink::WebFormControlElement element_;
193 193
194 // The form element currently requesting an interactive autocomplete. 194 // The form element currently requesting an interactive autocomplete.
195 blink::WebFormElement in_flight_request_form_; 195 blink::WebFormElement in_flight_request_form_;
196 196
197 // All the form elements seen in the top frame.
198 std::vector<blink::WebFormElement> form_elements_;
199
200 // Pointer to the WebView. Used to access page scale factor. 197 // Pointer to the WebView. Used to access page scale factor.
201 blink::WebView* web_view_; 198 blink::WebView* web_view_;
202 199
203 // Should we display a warning if autofill is disabled? 200 // Should we display a warning if autofill is disabled?
204 bool display_warning_if_disabled_; 201 bool display_warning_if_disabled_;
205 202
206 // Was the query node autofilled prior to previewing the form? 203 // Was the query node autofilled prior to previewing the form?
207 bool was_query_node_autofilled_; 204 bool was_query_node_autofilled_;
208 205
209 // Have we already shown Autofill suggestions for the field the user is 206 // Have we already shown Autofill suggestions for the field the user is
210 // currently editing? Used to keep track of state for metrics logging. 207 // currently editing? Used to keep track of state for metrics logging.
211 bool has_shown_autofill_popup_for_current_edit_; 208 bool has_shown_autofill_popup_for_current_edit_;
212 209
213 // If true we just set the node text so we shouldn't show the popup. 210 // If true we just set the node text so we shouldn't show the popup.
214 bool did_set_node_text_; 211 bool did_set_node_text_;
215 212
216 // Whether or not new forms/fields have been dynamically added
217 // since the last loaded forms were sent to the browser process.
218 bool has_new_forms_for_browser_;
219
220 // Whether or not to ignore text changes. Useful for when we're committing 213 // Whether or not to ignore text changes. Useful for when we're committing
221 // a composition when we are defocusing the WebView and we don't want to 214 // a composition when we are defocusing the WebView and we don't want to
222 // trigger an autofill popup to show. 215 // trigger an autofill popup to show.
223 bool ignore_text_changes_; 216 bool ignore_text_changes_;
224 217
225 // Whether the Autofill popup is possibly visible. This is tracked as a 218 // Whether the Autofill popup is possibly visible. This is tracked as a
226 // performance improvement, so that the IPC channel isn't flooded with 219 // performance improvement, so that the IPC channel isn't flooded with
227 // messages to close the Autofill popup when it can't possibly be showing. 220 // messages to close the Autofill popup when it can't possibly be showing.
228 bool is_popup_possibly_visible_; 221 bool is_popup_possibly_visible_;
229 222
(...skipping 21 matching lines...) Expand all
251 NoCancelOnSubframeNavigateAfterDone); 244 NoCancelOnSubframeNavigateAfterDone);
252 FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest, 245 FRIEND_TEST_ALL_PREFIXES(RequestAutocompleteRendererTest,
253 InvokingTwiceOnlyShowsOnce); 246 InvokingTwiceOnlyShowsOnce);
254 247
255 DISALLOW_COPY_AND_ASSIGN(AutofillAgent); 248 DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
256 }; 249 };
257 250
258 } // namespace autofill 251 } // namespace autofill
259 252
260 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_ 253 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_AUTOFILL_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698