Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 382193002: Upstream missing changes from HttpUrlRequest.java (Closed)

Created:
6 years, 5 months ago by mef
Modified:
6 years, 5 months ago
Reviewers:
tonycuadra, Charles, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Upstream missing changes from HttpUrlRequest interface and HttpUrlConnectionUrlRequest implementation. BUG=390267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282973

Patch Set 1 #

Patch Set 2 : Minor formatting fixes. #

Total comments: 2

Patch Set 3 : Limit uploadContentLength to int. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java View 1 2 7 chunks +41 lines, -2 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java View 1 1 chunk +11 lines, -0 lines 0 comments Download
M components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java View 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mef
6 years, 5 months ago (2014-07-11 13:44:16 UTC) #1
mmenke
https://codereview.chromium.org/382193002/diff/20001/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java File components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java (right): https://codereview.chromium.org/382193002/diff/20001/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java#newcode322 components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:322: (int)mUploadContentLength); Not really a big fan of casting and ...
6 years, 5 months ago (2014-07-11 20:04:06 UTC) #2
mef
Good point, I agree. https://codereview.chromium.org/382193002/diff/20001/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java File components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java (right): https://codereview.chromium.org/382193002/diff/20001/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java#newcode322 components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java:322: (int)mUploadContentLength); On 2014/07/11 20:04:05, mmenke ...
6 years, 5 months ago (2014-07-14 15:02:17 UTC) #3
mmenke
On 2014/07/14 15:02:17, mef wrote: > Good point, I agree. > > https://codereview.chromium.org/382193002/diff/20001/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequest.java > File ...
6 years, 5 months ago (2014-07-14 15:10:49 UTC) #4
mef
The CQ bit was checked by mef@chromium.org
6 years, 5 months ago (2014-07-14 16:14:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/382193002/40001
6 years, 5 months ago (2014-07-14 16:14:51 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:02:39 UTC) #7
Message was sent while issue was closed. 
Change committed as 282973

Powered by Google App Engine
This is Rietveld 408576698