Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

Issue 382193002: Upstream missing changes from HttpUrlRequest.java (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Limit uploadContentLength to int. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
diff --git a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
index 69449fb2a3c93474d3b4eefccf8ae54f2669cc5e..5e1a812158d24267d1791fd263182168e163d6ff 100644
--- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
+++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
@@ -206,7 +206,7 @@ public class CronetSampleActivity extends Activity {
return null;
}
- private void applyCommandLineToRequest(UrlRequest request) {
+ private void applyCommandLineToHttpUrlRequest(HttpUrlRequest request) {
String postData = getCommandLineArg(POST_DATA_KEY);
if (postData != null) {
InputStream dataStream = new ByteArrayInputStream(
@@ -214,6 +214,7 @@ public class CronetSampleActivity extends Activity {
ReadableByteChannel dataChannel = Channels.newChannel(dataStream);
request.setUploadChannel("text/plain", dataChannel,
postData.length());
+ request.setHttpMethod("POST");
}
}
@@ -224,12 +225,24 @@ public class CronetSampleActivity extends Activity {
HashMap<String, String> headers = new HashMap<String, String>();
HttpUrlRequestListener listener = new SampleHttpUrlRequestListener();
-
HttpUrlRequest request = mRequestFactory.createRequest(
url, UrlRequestPriority.MEDIUM, headers, listener);
+ applyCommandLineToHttpUrlRequest(request);
request.start();
}
+ private void applyCommandLineToUrlRequest(UrlRequest request) {
+ String postData = getCommandLineArg(POST_DATA_KEY);
+ if (postData != null) {
+ InputStream dataStream = new ByteArrayInputStream(
+ postData.getBytes());
+ ReadableByteChannel dataChannel = Channels.newChannel(dataStream);
+ request.setUploadChannel("text/plain", dataChannel,
+ postData.length());
+ request.setHttpMethod("POST");
+ }
+ }
+
public void startWithURL_UrlRequest(String url) {
Log.i(TAG, "Cronet started: " + url);
mUrl = url;
@@ -239,7 +252,7 @@ public class CronetSampleActivity extends Activity {
WritableByteChannel sink = Channels.newChannel(System.out);
UrlRequest request = new SampleRequest(mRequestContext, url,
UrlRequestPriority.MEDIUM, headers, sink);
- applyCommandLineToRequest(request);
+ applyCommandLineToUrlRequest(request);
request.start();
}
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlRequest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698