Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 382153007: Revert of Remove public_headers.gypi, unneeded by Skia. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, Torne
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Remove public_headers.gypi, unneeded by Skia. (https://codereview.chromium.org/381633003/) Reason for revert: Breaking canary: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/1207/steps/Update/logs/stdio Original issue's description: > Remove public_headers.gypi, unneeded by Skia. > > This file not needed by Skia, and is almost always out of date. > We recommend generating this inside Android WebView, where it is > used. Generating it is relatively straightforward; here is one way: > https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py > > BUG=skia:2350 > > Committed: https://skia.googlesource.com/skia/+/a3fce46f7c85eb3eb5c5373c1eaa0336d9756252 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2350 Committed: https://skia.googlesource.com/skia/+/c9af44add0db52888856cb822115c700280b6129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -0 lines) Patch
A gyp/public_headers.gypi View 1 chunk +292 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Remove public_headers.gypi, unneeded by Skia.
6 years, 5 months ago (2014-07-11 16:04:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/382153007/1
6 years, 5 months ago (2014-07-11 16:05:29 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 16:05:36 UTC) #3
Message was sent while issue was closed.
Change committed as c9af44add0db52888856cb822115c700280b6129

Powered by Google App Engine
This is Rietveld 408576698