Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 381633003: Remove public_headers.gypi, unneeded by Skia. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, Torne
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove public_headers.gypi, unneeded by Skia. This file not needed by Skia, and is almost always out of date. We recommend generating this inside Android WebView, where it is used. Generating it is relatively straightforward; here is one way: https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py BUG=skia:2350 Committed: https://skia.googlesource.com/skia/+/a3fce46f7c85eb3eb5c5373c1eaa0336d9756252

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -292 lines) Patch
D gyp/public_headers.gypi View 1 1 chunk +0 lines, -292 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scroggo
6 years, 5 months ago (2014-07-09 14:40:03 UTC) #1
scroggo
On 2014/07/09 14:40:03, scroggo wrote: Robert, Can you give me an LGTM? This does what ...
6 years, 5 months ago (2014-07-10 18:07:56 UTC) #2
robertphillips
lgtm
6 years, 5 months ago (2014-07-10 18:14:23 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-10 18:15:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/381633003/1
6 years, 5 months ago (2014-07-10 18:16:58 UTC) #5
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-10 22:25:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/381633003/20001
6 years, 5 months ago (2014-07-10 22:25:30 UTC) #7
commit-bot: I haz the power
Change committed as a3fce46f7c85eb3eb5c5373c1eaa0336d9756252
6 years, 5 months ago (2014-07-11 15:47:21 UTC) #8
scroggo
6 years, 5 months ago (2014-07-11 16:04:57 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/382153007/ by scroggo@google.com.

The reason for reverting is: Breaking canary:
http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-...

.

Powered by Google App Engine
This is Rietveld 408576698