Issue 382153003: Make UBSan happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 382153003: Make UBSan happy. (Closed)

Created:
6 years, 5 months ago by Sven Panne

Modified:
6 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Make UBSan happy. This involves avoiding signed multiplication overflow, shifting too far and overflow during negation. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22351

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -15 lines)			Patch
M	src/hydrogen-instructions.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/strtod.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

6 years, 5 months ago (2014-07-11 12:13:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22351 (presubmit successful).