src/strtod.cc - Issue 382153003: Make UBSan happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/strtod.cc

Issue 382153003: Make UBSan happy. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebased Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/strtod.cc

diff --git a/src/strtod.cc b/src/strtod.cc

index 877f1830b69286b94fa9a61eef46b24a1a09f88a..725a09da6f967a137ba0cf97b4274c5e418bad9c 100644

--- a/src/strtod.cc

+++ b/src/strtod.cc

@@ -247,7 +247,7 @@ static bool DiyFpStrtod(Vector<const char> buffer,

const int kDenominator = 1 << kDenominatorLog;

// Move the remaining decimals into the exponent.

exponent += remaining_decimals;

- int error = (remaining_decimals == 0 ? 0 : kDenominator / 2);

+ int64_t error = (remaining_decimals == 0 ? 0 : kDenominator / 2);

int old_e = input.e();

input.Normalize();

« no previous file with comments | « src/runtime.cc ('k') | src/utils.h » ('j') | no next file with comments »