net/socket/unix_domain_client_socket_posix_unittest.cc - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/unix_domain_client_socket_posix_unittest.cc

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Packing parameters to a stucture Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/android/devtools_auth.h ('K') | « content/public/browser/android/devtools_auth.h ('k') | net/socket/unix_domain_listen_socket_posix.cc » ('j') | net/socket/unix_domain_server_socket_posix.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/unix_domain_client_socket_posix_unittest.cc

diff --git a/net/socket/unix_domain_client_socket_posix_unittest.cc b/net/socket/unix_domain_client_socket_posix_unittest.cc

index d79112249291d04ea9a69d428eeddc68359484ea..e85dc19294bc354275ab0f29e2a37016ab720249 100644

--- a/net/socket/unix_domain_client_socket_posix_unittest.cc

+++ b/net/socket/unix_domain_client_socket_posix_unittest.cc

@@ -21,10 +21,14 @@ namespace {

const char kSocketFilename[] = "socket_for_testing";

-bool UserCanConnectCallback(bool allow_user, uid_t uid, gid_t gid) {

+bool UserCanConnectCallback(bool allow_user,

+ const UnixDomainServerSocket::Credentials& credentials) {

byungchul 2014/08/04 22:18:02 wrong indentation

SeRya 2014/08/05 10:32:27 Done.

// Here peers are running in same process.

- EXPECT_EQ(getuid(), uid);

- EXPECT_EQ(getgid(), gid);

+#if defined(OS_LINUX) || defined(OS_ANDROID)

+ EXPECT_EQ(getpid(), credentials.process_id);

+#endif

+ EXPECT_EQ(getuid(), credentials.user_id);

+ EXPECT_EQ(getgid(), credentials.group_id);

return allow_user;

}