content/public/browser/android/devtools_auth.h - Issue 382143005: Supports DevTools socket access authentication based on Android permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/devtools_auth.h

Issue 382143005: Supports DevTools socket access authentication based on Android permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Packing parameters to a stucture Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/dev_tools_server.cc ('K') | « content/browser/android/devtools_auth.cc ('k') | net/socket/unix_domain_client_socket_posix_unittest.cc » ('j') | net/socket/unix_domain_client_socket_posix_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/android/devtools_auth.h

diff --git a/content/public/browser/android/devtools_auth.h b/content/public/browser/android/devtools_auth.h

index 700892c034a00a8b3e15637e02cbdfb54a548b87..72e46de5c7dcca2bbadf1757121120878366f63d 100644

--- a/content/public/browser/android/devtools_auth.h

+++ b/content/public/browser/android/devtools_auth.h

@@ -6,14 +6,14 @@

#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_AUTH_ANDROID_H_

#include "content/common/content_export.h"

-#include <pwd.h>

+#include "net/socket/unix_domain_server_socket_posix.h"

namespace content {

// Returns true if the given user/group pair is authorized to connect to the

byungchul 2014/08/04 22:18:02 Update the comment.

SeRya 2014/08/05 10:32:27 Done.

// devtools server, false if not.

-CONTENT_EXPORT bool CanUserConnectToDevTools(uid_t uid, gid_t gid);

+CONTENT_EXPORT bool CanUserConnectToDevTools(

+ const net::UnixDomainServerSocket::Credentials& credentials);

} // namespace content